Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on DragonFly BSD #2794

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

mneumann
Copy link
Contributor

Also remove duplicate include. There is no netinet/ip_mroute.h and netinet/sctp.h on DragonFly.

@SeanTAllen
Copy link
Member

Thank you for this @mneumann.

I see you are a dragonfly committer. Do you know if any infrastructure for dragonfly we could run CI on to avoid breakage?

@@ -66,9 +66,10 @@ typedef int SOCKET;
#include <linux/udp.h>
#endif
#ifdef PLATFORM_IS_BSD
#ifndef __DragonFly__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be:

#ifdef PLATFORM_IS_DRAGONFLY

Which is defined in common/platform.h ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winksaville : thanks, I will fix this.

@mneumann
Copy link
Contributor Author

@SeanTAllen CI would probably be a lot of work to setup properly. For Rust we had a CI for DragonFly, which was a docker file that cross compiles Rust on Linux, but due to lack of resources of the Rust project, this never went into "production". FreeBSD and DragonFly share a common ports collection, and if a new release fails to build, we at least notice it there.

The pony runtime seems to be pretty well done, so I doubt there will be very often situations where things break. But of course I also have the desire for CI :). What I could do is to setup a daily cron job (or hourly whatever) that takes the most recent commit from github and compiles it, and reports build failures.

@SeanTAllen
Copy link
Member

@mneumann given lack of CI, that would be great. do you know if anyone has tried doing CI for dragonfly apps using something like qemu on TravisCI?

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jun 16, 2018
@SeanTAllen
Copy link
Member

Also, thanks for the contribution @mneumann. Wonderful first contribution.

@SeanTAllen SeanTAllen merged commit 1572e12 into ponylang:master Jun 16, 2018
ponylang-main added a commit that referenced this pull request Jun 16, 2018
@SeanTAllen
Copy link
Member

Unrelated to anything. Dragonfly is one of my two favorite Unixes out there today. I did the original port because I hoped to start using Pony on Dragonfly. Sadly, haven't had a chance yet. Thanks for getting this working again. I haven't had time to spin up and test very often.

@mneumann
Copy link
Contributor Author

@SeanTAllen some time ago, I also did made pony work on DragonFly as I wanted to try it out, but my patch contained too much platform specific changes. It's good to see that you have done it the right way (e.g. PLATFORM_IS_BSD instead of PLATFORM_IS_FREEBSD everywhere). Sadly, I didn't had a chance either to use Pony much. But I am so happy that it builds just with a few lines of changes out of the box.

@mneumann mneumann deleted the fix-ponyc-on-dragonfly branch June 17, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants