Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ponyc-standalone.lib for windows #4307

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Conversation

mfelsche
Copy link
Contributor

Build ponyc-standalone.lib for windows as a standalone variant of libponyc. It contains blake2, LLVM libs and libponyc.
It does not (to my knowledge) contain any static system libraries yet, but pony programs linked against it, work fine as is.

Linking to it from a pony program is done in the exact same way as for the other supported platforms:

use "lib:ponyc-standalone" if linux or osx or windows
use "lib:c++" if osx

actor Main
  new create(env: Env) =>
    None

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 18, 2023
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Jan 20, 2023
@ponylang-main
Copy link
Contributor

Hi @mfelsche,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4307.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

@mfelsche can you add release notes for this that mirror the final version of the MacOS release notes except for Windows? Then this should be good to merge.

@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Jan 24, 2023
Matthias Wahl and others added 4 commits January 24, 2023 21:35
as a standalone variant of libponyc. It contains blake2, LLVM libs and libponyc.
It does not (to my knowledge) contain any static system libraries yet, but pony programs linked against it, work fine as is.

```pony
use "lib:ponyc-standalone" if posix or osx or windows
use "lib:c++" if osx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a libc++ not needed for windows? are we statically linking one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those are always statically linked. I was testing this successfully on my Windows 10 machine.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 25, 2023
@SeanTAllen SeanTAllen merged commit dbdf2f0 into main Jan 26, 2023
@SeanTAllen SeanTAllen deleted the windows-ponyc-standalone branch January 26, 2023 21:00
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 26, 2023
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants