Skip to content

Commit 83f2f84

Browse files
committed
Show version of nodes in output of TAP tests
This commit adds the version information of a node initialized by Cluster.pm, that may vary depending on the install_path given by the test. The code was written so as the node information, that includes the version number, was dumped before the version number was set. This is particularly useful for the pg_upgrade TAP tests, that may mix several versions for cross-version runs. The TAP infrastructure also allows mixing nodes with different versions, so this information can be useful for out-of-core tests. Backpatch down to v15, where Cluster.pm and the pg_upgrade TAP tests have been introduced. Author: Potapov Alexander <a.potapov@postgrespro.com> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/e59bb-692c0a80-5-6f987180@170377126 Backpatch-through: 15
1 parent 904f9f5 commit 83f2f84

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/test/perl/PostgreSQL/Test/Cluster.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1647,10 +1647,10 @@ sub new
16471647
or
16481648
BAIL_OUT("could not create data directory \"$node->{_basedir}\": $!");
16491649

1650-
$node->dump_info;
1651-
16521650
$node->_set_pg_version;
16531651

1652+
$node->dump_info;
1653+
16541654
my $ver = $node->{_pg_version};
16551655

16561656
# Use a subclass as defined below (or elsewhere) if this version

0 commit comments

Comments
 (0)