[Issue #66] for LSN mode data_checksums must be enabled

Author: gsmolk

src/dir.c

@@ -1208,8 +1208,9 @@ read_tablespace_map(parray *files, const char *backup_dir)
  * If tablespace-mapping option is supplied, all OLDDIR entries must have
  * entries in tablespace_map file.
  *
- * When running incremental restore with tablespace remapping, then
- * new tablespace directory MUST be empty, because there is no
+ *
+ * TODO: maybe when running incremental restore with tablespace remapping, then
+ * new tablespace directory MUST be empty? because there is no
  * we can be sure, that files laying there belong to our instance.
  */
 void

src/pg_probackup.h

@@ -105,6 +105,7 @@ typedef struct RedoParams
 {
 	TimeLineID  tli;
 	XLogRecPtr  lsn;
+	uint32      checksum_version;
 } RedoParams;
 
 typedef struct PageState

src/restore.c

@@ -411,6 +411,10 @@ do_restore_or_validate(time_t target_backup_id, pgRecoveryTarget *rt,
 		parray	  *timelines = NULL;
 		get_redo(instance_config.pgdata, &redo);
 
+		if (redo.checksum_version == 0)
+			elog(ERROR, "Incremental restore in 'lsn' mode require "
+				"data_checksums to be enabled in destination data directory");
+
 		timelines = read_timeline_history(arclog_path, redo.tli, false);
 
 		if (!timelines)

src/util.c

@@ -380,6 +380,8 @@ get_redo(const char *pgdata_path, RedoParams *redo)
 		redo->lsn = ControlFile.backupStartPoint;
 		redo->tli = ControlFile.checkPointCopy.ThisTimeLineID;
 	}
+
+	redo->checksum_version = ControlFile.data_checksum_version;
 }
 
 /*