Merge branch 'master' into release_2_5

Author: gsmolk

doc/pgprobackup.xml

@@ -1874,6 +1874,10 @@ pg_probackup restore -B <replaceable>backup_dir</replaceable> --instance <replac
         you must drop the excluded databases using
         <command>DROP DATABASE</command> command.
       </para>
+      <para>
+        If want to decouple a single cluster with multiple databases into separate clusters with minimal downtime, then
+        you can partially restore cluster as standby via <option>--restore-as-replica</option> options.
+      </para>
       <note>
         <para>
           The <literal>template0</literal> and

src/utils/remote.c

@@ -82,6 +82,11 @@ void wait_ssh(void)
 #endif
 }
 
+/*
+ * On windows we launch a new pbk process via 'pg_probackup ssh ...'
+ * so this process would new that it should exec ssh, because
+ * there is no fork on Windows.
+ */
 #ifdef WIN32
 void launch_ssh(char* argv[])
 {

tests/backup.py

@@ -1968,7 +1968,7 @@ def test_basic_missing_dir_permissions(self):
                 '\n Unexpected Error Message: {0}\n CMD: {1}'.format(
                     repr(e.message), self.cmd))
 
-        os.chmod(full_path, 700)
+        os.rmdir(full_path)
 
         # Clean after yourself
         self.del_test_dir(module_name, fname, [node])
@@ -2899,3 +2899,34 @@ def test_issue_203(self):
 
         # Clean after yourself
         self.del_test_dir(module_name, fname)
+
+    # @unittest.skip("skip")
+    def test_issue_231(self):
+        """
+        https://github.com/postgrespro/pg_probackup/issues/231
+        """
+        fname = self.id().split('.')[3]
+        backup_dir = os.path.join(self.tmp_path, module_name, fname, 'backup')
+        node = self.make_simple_node(
+            base_dir=os.path.join(module_name, fname, 'node'),
+            set_replication=True,
+            initdb_params=['--data-checksums'],
+            pg_options={'autovacuum': 'off'})
+
+        self.init_pb(backup_dir)
+        self.add_instance(backup_dir, 'node', node)
+        node.slow_start()
+
+        datadir = os.path.join(node.data_dir, '123')
+
+        try:
+            self.backup_node(
+                backup_dir, 'node', node,
+                data_dir='{0}'.format(datadir), return_id=False)
+        except:
+            pass
+
+        self.backup_node(backup_dir, 'node', node, options=['--stream'])
+
+        # Clean after yourself
+        self.del_test_dir(module_name, fname)