enforce some checks (flake8)

Author: funbringer

setup.cfg

@@ -2,5 +2,5 @@
 description-file = README.md
 
 [flake8]
-ignore = E501, F401, F403, F841
-exclude = .git,__pycache__,env,venv
+ignore = E501
+exclude = .git,__pycache__,env,venv,testgres/__init__.py

testgres/node.py

@@ -36,7 +36,6 @@
 
 from .utils import \
     get_bin_path, \
-    get_pg_version, \
     pg_version_ge as _pg_version_ge, \
     reserve_port as _reserve_port, \
     release_port as _release_port, \
@@ -159,7 +158,7 @@ def print_node_file(node_file):
                 try:
                     with io.open(node_file, "r") as f:
                         return f.read().decode('utf-8')
-                except Exception as e:
+                except Exception:
                     pass
             return "### file not found ###\n"
 
@@ -389,7 +388,7 @@ def start(self, params=[]):
 
         try:
             _execute_utility(_params, self.utils_log_name)
-        except ExecUtilException as e:
+        except ExecUtilException:
             msg = (
                 u"Cannot start node\n"
                 u"{}\n"    # pg_ctl log
@@ -447,7 +446,7 @@ def restart(self, params=[]):
 
         try:
             _execute_utility(_params, self.utils_log_name)
-        except ExecUtilException as e:
+        except ExecUtilException:
             msg = (
                 u"Cannot restart node\n"
                 u"{}\n"    # pg_ctl log
@@ -525,9 +524,9 @@ def cleanup(self, max_attempts=3):
             try:
                 self.stop()
                 break    # OK
-            except ExecUtilException as e:
+            except ExecUtilException:
                 pass    # one more time
-            except Exception as e:
+            except Exception:
                 break    # screw this
 
             attempts += 1

tests/test_simple.py

@@ -294,12 +294,12 @@ def test_backup_exhaust(self):
             with node.backup(xlog_method='fetch') as backup:
 
                 # exhaust backup by creating new node
-                with backup.spawn_primary('node1') as node1:
+                with backup.spawn_primary('node1') as node1:  # noqa
                     pass
 
                 # now let's try to create one more node
                 with self.assertRaises(BackupException):
-                    with backup.spawn_primary('node2') as node2:
+                    with backup.spawn_primary('node2') as node2:  # noqa
                         pass
 
     def test_backup_and_replication(self):
@@ -567,7 +567,6 @@ def test_version_management(self):
 
     def test_config(self):
         # set global if it wasn't set
-        pg_config = get_pg_config()
         configure_testgres(cache_initdb=True, cache_pg_config=True)
 
         # check same instances