Use punycode on encoder.encodeHost for browser

Author: codenirvana

CHANGELOG.yaml

@@ -1,3 +1,7 @@
+unreleased:
+  fixed bugs:
+    - Fixed a bug where `encoder.encodeHost` throws in the browser
+
 3.0.4:
   date: 2021-08-09
   fixed bugs:

encoder/index.js

@@ -44,9 +44,7 @@
  * @see {@link https://tools.ietf.org/html/rfc3986#section-3}
  */
 
-const domainToASCII = require('url').domainToASCII,
-
-    encodeSet = require('./encode-set'),
+const encodeSet = require('./encode-set'),
 
     _percentEncode = require('./percent-encode').encode,
     _percentEncodeCharCode = require('./percent-encode').encodeCharCode,
@@ -69,7 +67,30 @@ const domainToASCII = require('url').domainToASCII,
     OBJECT = 'object',
 
     PATH_SEPARATOR = '/',
-    DOMAIN_SEPARATOR = '.';
+    DOMAIN_SEPARATOR = '.',
+
+    /**
+     * Returns the Punycode ASCII serialization of the domain.
+     *
+     * @private
+     * @function
+     * @param {String} domain domain name
+     * @returns {String} punycode encoded domain name
+     */
+    domainToASCII = (function () {
+        // @note `url.domainToASCII` returns empty string for invalid domain.
+        const domainToASCII = require('url').domainToASCII;
+
+        // use faster native `url` method in Node.js
+        /* istanbul ignore next */
+        if (typeof domainToASCII === 'function') {
+            return domainToASCII;
+        }
+
+        // else, lazy load `punycode` dependency in browser
+        /* istanbul ignore next */
+        return require('punycode').toASCII;
+    }());
 
 /**
  * Returns the Punycode ASCII serialization of the domain.

package-lock.json

@@ -30,6 +30,9 @@
     "test-system": "node npm/test-system.js",
     "test-unit": "nyc --nycrc-path=.nycrc.js node npm/test-unit.js"
   },
+  "dependencies": {
+    "punycode": "^2.1.1"
+  },
   "devDependencies": {
     "@postman/csv-parse": "^4.0.2",
     "@postman/shipit": "^0.3.0",