New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line breaking in mobile nothing found page #2830

Merged
merged 4 commits into from Mar 29, 2018

Conversation

3 participants
@MegaApplePi
Contributor

MegaApplePi commented Mar 27, 2018

fixes #2078

@@ -91,7 +91,8 @@ class Beatmaps.Main extends React.PureComponent
src: '/images/layout/beatmaps/not-found.png'
alt: osu.trans("beatmaps.listing.search.not-found")
title: osu.trans("beatmaps.listing.search.not-found")
osu.trans("beatmaps.listing.search.not-found-quote")
div className: 'beatmapsets__empty--message',

This comment has been minimized.

@nanaya

nanaya Mar 28, 2018

Collaborator

not needed (see below). Also can't have modifier without its element.

width: 100%;
margin: 10px 0 -20px;
&--message{
align-self: center;

This comment has been minimized.

@nanaya

nanaya Mar 28, 2018

Collaborator

add align-items: center in the element instead.

MegaApplePi added some commits Mar 28, 2018

@peppy peppy changed the title from fix line breaking in mobile nothing found page to Fix line breaking in mobile nothing found page Mar 29, 2018

@nanaya

nanaya approved these changes Mar 29, 2018

@nanaya nanaya merged commit 1e56dad into ppy:master Mar 29, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MegaApplePi MegaApplePi deleted the MegaApplePi:mobile-nope-nothing-found branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment