disabling-doubleposts feature #424

Risers · 2016-03-12T20:26:41Z

Doubleposting is disabled server-side and user-side. Users can doublepost 3 days after last post.
User that created topic can doublepost every 24h.

app/Models/Forum/Topic.php

+            return false;
+        }
+        if ($user->user_id === $this->topic_poster) {
+            if (Carbon::now()->subdays(1) > $this->topic_last_post_time) {


peppy · 2016-03-14T07:48:32Z

what's with all the file permission changes? might want to check your git setup.

LiquidPL · 2016-03-14T07:50:03Z

This gets created on a clean vagrant provision iirc

Sakisan · 2016-03-14T10:14:33Z

I also get these modifications automatically right after the installation by vagrant.

~/projects/osu-web/code on master !
➜ gss
 M bootstrap/cache/.keep
 M storage/.gitignore
 M storage/app/.gitignore
 M storage/clockwork/.gitignore
 M storage/framework/.gitignore
 M storage/framework/cache/.gitignore
 M storage/framework/sessions/.gitignore
 M storage/framework/views/.gitignore
 M storage/htmlpurifier/.keep
 M storage/logs/.gitignore

No one noticed this before?

LiquidPL · 2016-03-14T10:42:56Z

I did, but I didn't really care to bring that up

Sakisan · 2016-03-15T11:14:26Z

I guess the quick fix is to just let these files be merged. I don't think that would be a problem.

Risers · 2016-03-21T12:54:02Z

Kinda up?

app/Models/Forum/Topic.php

@@ -425,4 +426,30 @@ public function deleteWithCover()

        $this->delete();
    }
+
+    public function isADoublePost(User $user)


nanaya · 2016-04-11T06:53:34Z

what's with so many "style fixes" commit?
don't change permission of unrelated files. And, no, those files should not be executable.
once activated (and is double post) the box can't be hidden since close button is obstructed by the overlay
if the user has slow connection, he will be able to write something and then later the overlay appears
every reply box activation triggers network round trip. Especially noticeable when scrolling back and forth from the bottom of the page while writing a reply

Risers · 2016-04-11T09:16:40Z

Thanks

Update post-box.coffee Update forum-post.less Update forum-post.less Update Authorize.php Update TopicsController.php Update forum-topic-reply.coffee Update Topic.php Update osu.php Update forum-topic-reply.coffee file modes changed

cleaning warnings

cleaning styleCl Update forum-post.less adding deleted empty lines

postbox opverlay is now displayed afer post

Risers · 2016-06-01T19:49:24Z

Done

app/Models/Forum/Topic.php

+            return false;
+        }
+        if ($user->user_id === $this->topic_poster) {
+            if (Carbon::now()->subhours(config('osu.forum.authorDoublePostTime')) > $this->topic_last_post_time) {


nanaya · 2016-06-07T08:38:06Z

Just make it like this

In resources/views/forum/topics/show.blade.php around line 137:

<div class="forum-post__content forum-post__content forum-post__content--edit-bar">
    @if (priv_check('ForumTopicReply', $topic)->can())
        @include("forum.topics._post_box_footer", ["submitText" => trans("forum.topic.post_reply")])
    @else
        <span>
            <i class="fa fa-warning"></i>
            {{ priv_check('ForumTopicReply', $topic)->message() }}
        </span>
    @endif
</div>

And add relevant check in app/Libraries/OsuAuthorize.php, function checkForumTopicReply. Also move the error message translation to authorization.php file.

Cleaning warnings

cleaning code cleaning code

Risers · 2016-06-20T15:51:22Z

Done

config/osu.php

@@ -29,6 +29,10 @@
    'forum' => [
        'admin_forum_id' => intval(env('ADMIN_FORUM_ID', 28)),
        'help_forum_ids' => array_map('intval', explode(' ', env('HELP_FORUM_IDS', '4 5 29 30 101'))),
+        'doublePostTime' => [


Risers · 2016-06-21T08:34:19Z

Done

Risers added 9 commits March 12, 2016 21:07

disabling-doubleposts feature

d807fa7

Merge branch 'master' into master

e9b6611

Cleaning stylecl errors

0ed60b5

Cleaning stylecl errors

4b4a2c8

Cleaning stylecl errors

93896df

Cleaning stylecl errors

a42bfd4

Cleaning stylecl errors

db4a141

Cleaning stylecl errors

e36a1cb

Cleaning stylecl errors

5035ac0

LiquidPL mentioned this pull request Mar 13, 2016

Can still see post form in locked threads #425

Closed

Risers mentioned this pull request Mar 13, 2016

Disallow double-posting on forum #31

Closed

peppy reviewed Mar 14, 2016
View reviewed changes

app/Models/Forum/Topic.php

return false;

}

if ($user->user_id === $this->topic_poster) {

if (Carbon::now()->subdays(1) > $this->topic_last_post_time) {

This comment was marked as off-topic.

Sign in to view

Risers added 4 commits March 15, 2016 17:55

merge error fixed

c62c2da

Time between doubleposts is config level

a4122f4

Merge branch 'master' into master

e230cb8

Merge branch 'master' into master

006ec22

Merge branch 'master' into master

f5f653d

nanaya reviewed Apr 11, 2016
View reviewed changes

app/Models/Forum/Topic.php

@@ -425,4 +426,30 @@ public function deleteWithCover()

$this->delete();

}

public function isADoublePost(User $user)

This comment was marked as off-topic.

Sign in to view

Risers added 7 commits May 31, 2016 20:48

Update Topic.php

2a64cdf

Update post-box.coffee Update forum-post.less Update forum-post.less Update Authorize.php Update TopicsController.php Update forum-topic-reply.coffee Update Topic.php Update osu.php Update forum-topic-reply.coffee file modes changed

Merge pull request #2 from Risers/test

dea8ddc

cleaning warnings

Merge remote-tracking branch 'upstream/master'

592047e

cleaning merge errors

747feaf

cleaning styleCl Update forum-post.less adding deleted empty lines

cleaning bugs

bf99186

Merge remote-tracking branch 'upstream/master'

4e83fb4

stylecl

2218870

postbox opverlay is now displayed afer post

nanaya reviewed Jun 7, 2016
View reviewed changes

app/Models/Forum/Topic.php

return false;

}

if ($user->user_id === $this->topic_poster) {

if (Carbon::now()->subhours(config('osu.forum.authorDoublePostTime')) > $this->topic_last_post_time) {

This comment was marked as off-topic.

Sign in to view

Risers added 2 commits June 20, 2016 17:05

Merge remote-tracking branch 'upstream/master'

b15f35e

Cleaning warnings

cleaning styleCi

16fc5dc

cleaning code cleaning code

nanaya reviewed Jun 21, 2016
View reviewed changes

config/osu.php

@@ -29,6 +29,10 @@

'forum' => [

'admin_forum_id' => intval(env('ADMIN_FORUM_ID', 28)),

'help_forum_ids' => array_map('intval', explode(' ', env('HELP_FORUM_IDS', '4 5 29 30 101'))),

'doublePostTime' => [

This comment was marked as off-topic.

Sign in to view

adding snake_casing

703a5e1

nanaya merged commit 2efe77c into ppy:master Jun 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disabling-doubleposts feature #424

disabling-doubleposts feature #424

Risers commented Mar 12, 2016

This comment was marked as off-topic.

peppy commented Mar 14, 2016

LiquidPL commented Mar 14, 2016

Sakisan commented Mar 14, 2016

LiquidPL commented Mar 14, 2016

Sakisan commented Mar 15, 2016

Risers commented Mar 21, 2016

This comment was marked as off-topic.

nanaya commented Apr 11, 2016

Risers commented Apr 11, 2016

Risers commented Jun 1, 2016

This comment was marked as off-topic.

nanaya commented Jun 7, 2016 •

edited

Loading

Risers commented Jun 20, 2016

This comment was marked as off-topic.

Risers commented Jun 21, 2016

disabling-doubleposts feature #424

disabling-doubleposts feature #424

Conversation

Risers commented Mar 12, 2016

This comment was marked as off-topic.

peppy commented Mar 14, 2016

LiquidPL commented Mar 14, 2016

Sakisan commented Mar 14, 2016

LiquidPL commented Mar 14, 2016

Sakisan commented Mar 15, 2016

Risers commented Mar 21, 2016

This comment was marked as off-topic.

nanaya commented Apr 11, 2016

Risers commented Apr 11, 2016

Risers commented Jun 1, 2016

This comment was marked as off-topic.

nanaya commented Jun 7, 2016 • edited Loading

Risers commented Jun 20, 2016

This comment was marked as off-topic.

Risers commented Jun 21, 2016

nanaya commented Jun 7, 2016 •

edited

Loading