Per-playlist item max attempts #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Feb 4, 2021
| $room->startPlay($user, $playlistItem1); | ||
| } | ||
|
|
||
| public function testMaxAttemptsForItemReached() |
There was a problem hiding this comment.
This looks like it's just testing the same thing twice, the previous test checks that the room limit is hit, this one should probably be checking the playlist limit is hit but not the room limit, so maybe it should be testing is other plays can still be started?
There was a problem hiding this comment.
it's already testing whether other item can still be started, just no assertion (now added).
notbakaneko
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7150.