Integrate new chat into game

[jai-x]

• Closes Implement Chat Overlay redesign #17001
• Resolves Chat dropdown can extend beyond the screen #10541
• Resolves Chat tabs towards the right edge disappears when opened #10128

Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/

2022-05-23_22-31-09.mp4

Integrates ChatOverlayV2 into game, matching existing functionality and passing existing tests

Manual flows tested:

• Joining channels
• Leaving channels
• Chatting in public channels
• Chatting in DM channels
• Opening DM channel from user overlay
• Opening a channel from a mention notification
• Opening DM channel from a DM notification

Features present in design but not in this PR:

• Mention count appearing in the channel list
• Unread state appearing in the channel list
• Filtering channel list visibility by type
• Font resizing
• Search
• Overlay minimised display

[Joehuu]

I added some issues that the redesign resolves, but I'm not sure about these behavioral ones:

• Joining a channel with no channels joined does not always automatically select the new channel #5152
• Channel selector will close when the channel is switched indirectly #5157
• Channel selector will not automatically open if there are no channels joined #5161

I think they are fixed, as the channel selector is now in the same place as chat.

---

I haven't been following the implementations, but there are some parts that I think should be different:

• the "Add more channels" should be a simple + because it blends in with other text
• it defaults to the channel selector instead of the first tab after every relaunch
• "osu!chat" should just be "chat" (to match toolbar title, notably)

[jai-x]

• the "Add more channels" should be a simple + because it blends in with other text

At the moment, I've just implemented as is specified in the design, which may change and evolve from usability feedback.
I do notice that the design has already been updated with new "+" icons but I'm unsure exactly how they are supposed to function.
I have asked about them in a Figma comment.

• it defaults to the channel selector instead of the first tab after every relaunch

This is because the overlay binds and sets the current channel to a non-null value before the channel manager can poll and join the default channels. Oversight, will fix.

• "osu!chat" should just be "chat" (to match toolbar title, notably)

This is just placeholder design, as the top bar will have channel filters added in subsequent PR as per design.

[peppy]

I haven't investigated the cause in detail yet, but on a release build this doesn't load any channels for me:

I guess the live release doesn't either...

[jai-x]

I'm able to connect to chat fine on the latest release, master, and on this branch. Seems like very weird failure :/

[peppy]

It's a non-issue, I've found the cause and will fix separately.

[peppy]

This isn't working as expected. The order here is not the visual order and therefore results in weird traversal:

osu.2022-05-25.at.09.43.37.mp4

Also, the channel scroll view should be re-centering itself after selecting a new channel via keyboard. You can call ScrollIntoView on the drawable to make this happen.

[jai-x]

Is this change correct? It implies that channels like multiplayer channels should show up in the overlay?

[peppy]

probably not, but should show that the function is not clear. i was changing it to fix traversal and things like announce channels not being considered.

it should be written to exclude rather than include, i think.

[peppy]

For whatever it's worth, announcements now show up in this display:

A further step (separate PR) would give them a heading, but also only show that section if any announcement channels are actually present.

[jai-x]

Yeah this was intended as, since the channel filter method changed, I decided that the top "CHANNELS" section would be the catch all for all types of channel except for DMs. Will improve in a follow up PR 👍