Fix reverse selection not updating new combo location #27723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
reviewed
Mar 26, 2024
|
Unit tests missing. |
bdach
reviewed
Mar 26, 2024
Since it appears that there is no tests for reverse pattern yet, would it be correct to start adding them to TestSceneOsuComposerSelection and create a new one for catch at here ? |
Sure. |
|
Since the tests got so big i decided to create its own classes for it: TestSceneOsuReverseSelection and TestSceneCatchReverseSelection |
|
@64ArthurAraujo i've simplfied the implementation of the fix and also significantly simplified the test coverage. please make sure to check those changes so that future changes can take less time to get in. |
bdach
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #27319 (both catch and standard).
before.mp4
after.mp4