Keep mod customisation panel open when dragging outside #29541
Conversation
| { | ||
| ExpandedState.Value = ModCustomisationPanelState.Collapsed; | ||
| if (!ReceivePositionalInputAt(inputManager!.CurrentState.Mouse.Position) && inputManager.DraggedDrawable == null) |
There was a problem hiding this comment.
Bit baffled by this NRT usage, why declare inputManager as InputManager? if you're just going to silence null inspections at point of usage here? Just make the field non-nullable from the start?
Also is there any point to splitting this into two nested ifs rather than adding a third condition?
There was a problem hiding this comment.
Sure I can silence it elsewhere.
Two ifs read better to me, not a big fan of very long conditionals. Probably just me.
There was a problem hiding this comment.
Silence at point of assignment IMO.
|
I don't know if I should report it, but there is a super edge case where the panel doesn't collapse if you are dragging a slider that is NOT in the customisation panel. This could be reproduced by the following steps:
2024-08-23.17-55-44-encoded.mp4 |
|
Don't think it matters. |
Really wish hover is not being eaten from the
FocusGrabbingContainerso we don't have to doReceivePositionalInputAtbut I don't think it's worth checking on that.