fix: Fix writing binary PNG content to screenshot files

prantlf · prantlf · commit ad720cb6afa1 · 2018-01-29T03:01:09.000+01:00
diff --git a/tasks/html-dom-snapshot.js b/tasks/html-dom-snapshot.js
@@ -291,7 +291,7 @@ module.exports = function (grunt) {
           return ensureDirectory(screenshots)
             .then(function () {
               return new Promise(function (resolve, reject) {
-                fs.writeFile(target, png, function (error) {
+                fs.writeFile(target, new Buffer(png.value, 'base64'), function (error) {
                   if (error) {
                     reject(error);
                   } else {
diff --git a/test/test.js b/test/test.js
@@ -25,9 +25,9 @@ exports['html-dom-snapshot'] = {
 
   'static': function (test) {
     const snapshot = fs.existsSync('test/snapshots/static.html'),
-          screenshot = fs.readFileSync('test/screenshots/static.png');
+          screenshot = fs.statSync('test/screenshots/static.png');
     test.ok(!snapshot, 'static.html');
-    test.ok(screenshot, 'static.png');
+    test.ok(screenshot.size > 1024, 'static.png');
     test.done();
   },
 
@@ -41,9 +41,9 @@ exports['html-dom-snapshot'] = {
   'dynamic': function (test) {
     const pages = readPages('dynamic.html'),
           expected = pages.expected.replace('<body>', '<body class="dynamic">'),
-          screenshot = fs.readFileSync('test/screenshots/dynamic.png');
+          screenshot = fs.statSync('test/screenshots/dynamic.png');
     test.equal(expected, pages.actual, 'dynamic.html');
-    test.ok(screenshot, 'dynamic.png');
+    test.ok(screenshot.size > 1024, 'dynamic.png');
     test.done();
   },
 
