Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the router flicker #337

Merged
merged 9 commits into from
Feb 22, 2021

Conversation

cristianbote
Copy link
Member

Fixes #221.

Looking to add a test for this.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2021

Size Change: +767 B (0%)

Total Size: 689 kB

Filename Size Change
packages/wmr/demo/dist/about/index.html 656 B +19 B (+3%)
packages/wmr/demo/dist/chunks/index.********.js 197 B -105 B (-35%) 🎉
packages/wmr/demo/dist/chunks/prerender.********.js 2.45 kB +1 B (0%)
packages/wmr/demo/dist/class-fields/index.html 634 B +21 B (+3%)
packages/wmr/demo/dist/compat/index.html 1.42 kB +21 B (+2%)
packages/wmr/demo/dist/env/index.html 712 B +20 B (+3%)
packages/wmr/demo/dist/error/index.html 646 B +23 B (+4%)
packages/wmr/demo/dist/files/index.html 675 B +19 B (+3%)
packages/wmr/demo/dist/index.********.js 7.03 kB +72 B (+1%)
packages/wmr/demo/dist/index.html 702 B +20 B (+3%)
packages/wmr/demo/dist/lazy-and-late/index.html 656 B +656 B (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
packages/wmr/demo/dist/assets/Calendar.********.css 702 B 0 B
packages/wmr/demo/dist/assets/style.********.css 386 B 0 B
packages/wmr/demo/dist/chunks/class-fields.********.js 200 B 0 B
packages/wmr/demo/dist/chunks/compat.********.js 15.3 kB 0 B
packages/wmr/wmr.cjs 656 kB 0 B

compressed-size-action

@cristianbote cristianbote changed the title Attempt to dix the router flicker Attempt to fix the router flicker Feb 17, 2021
@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

🦋 Changeset detected

Latest commit: 3499d93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cristianbote cristianbote marked this pull request as ready for review February 19, 2021 07:10
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Cristian!

@cristianbote
Copy link
Member Author

Based on recent findings I've included an update(1) in componentDidCatch in order to pickup on the changes. @developit I think now this is pretty safe for nested thrown promises, cause it does not read any children static property.

Is there any reason why this would lead to bad perf?

Let me know your thoughts.

@JoviDeCroock JoviDeCroock merged commit 438be29 into main Feb 22, 2021
@JoviDeCroock JoviDeCroock deleted the attempt-to-fix-the-router-flicker branch February 22, 2021 08:33
@github-actions github-actions bot mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old and new components in DOM on url change with preact-iso Router
3 participants