Router params: use Jest's ESM support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JoviDeCroock
approved these changes
Feb 21, 2021
JoviDeCroock
added a commit
that referenced
this pull request
Feb 21, 2021
* support route parameters and inject them into the component * add changeset * cleanup residual variables * fix lint-staged * reduce diff * always return undefined * add tests * remove log * update readme * fix indentation * Update packages/preact-iso/router.js Co-authored-by: Marvin Hagemeister <hello@marvinh.dev> * use correct yml syntax * use context for route * use createElement (avoid jsx) * Update neat-wasps-mix.md * remove unused import * Update packages/preact-iso/router.js Co-authored-by: Jason Miller <developit@users.noreply.github.com> * Use Jest's native ESM support (#357) * lint fixes * TypeScript fixes * add type for useRoute Co-authored-by: Marvin Hagemeister <hello@marvinh.dev> Co-authored-by: Jason Miller <developit@users.noreply.github.com> Co-authored-by: Jason Miller <jason@developit.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest supports Node's native ESM now, and it seems to work nicely! A quick test shows it's around 30% faster, which is pretty nice.