Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(preact-iso) - trim leading and trailing slash #416

Merged
merged 12 commits into from
Mar 14, 2021
Merged

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Mar 9, 2021

Fixes #415
Fixes #414

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2021

🦋 Changeset detected

Latest commit: 7ae310b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

Size Change: +84 B (0%)

Total Size: 690 kB

Filename Size Change
packages/wmr/demo/dist/about/index.html 657 B +1 B (0%)
packages/wmr/demo/dist/chunks/compat.********.js 15.3 kB -1 B (0%)
packages/wmr/demo/dist/chunks/index.********.js 197 B -2 B (-1%)
packages/wmr/demo/dist/chunks/prerender.********.js 2.44 kB +2 B (0%)
packages/wmr/demo/dist/class-fields/index.html 635 B +1 B (0%)
packages/wmr/demo/dist/compat/index.html 1.49 kB -1 B (0%)
packages/wmr/demo/dist/error/index.html 646 B +1 B (0%)
packages/wmr/demo/dist/index.********.js 7.15 kB +82 B (+1%)
packages/wmr/wmr.cjs 657 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/wmr/demo/dist/assets/Calendar.********.css 702 B 0 B
packages/wmr/demo/dist/assets/style.********.css 386 B 0 B
packages/wmr/demo/dist/chunks/class-fields.********.js 200 B 0 B
packages/wmr/demo/dist/env/index.html 712 B 0 B
packages/wmr/demo/dist/files/index.html 675 B 0 B
packages/wmr/demo/dist/index.html 703 B 0 B
packages/wmr/demo/dist/lazy-and-late/index.html 657 B 0 B

compressed-size-action

JoviDeCroock and others added 3 commits March 11, 2021 22:23
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@@ -19,8 +19,8 @@ const UPDATE = (state, url, push) => {
};

export const exec = (url, route, matches) => {
url = url.trim('/').split('/');
route = (route || '').trim('/').split('/');
url = url.split('/').filter(Boolean);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked because I was curious: The issue is that trim() has no arguments and only trims whitespace. So the original code was wrong to begin with.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah that's my bad.

@JoviDeCroock JoviDeCroock merged commit f320e3e into main Mar 14, 2021
@JoviDeCroock JoviDeCroock deleted the route-slashes branch March 14, 2021 21:09
@github-actions github-actions bot mentioned this pull request Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants