(preact-iso) - trim leading and trailing slash #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ae310b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +84 B (0%) Total Size: 690 kB
ℹ️ View Unchanged
|
JoviDeCroock
commented
Mar 9, 2021
developit
reviewed
Mar 11, 2021
developit
reviewed
Mar 11, 2021
JoviDeCroock
commented
Mar 11, 2021
JoviDeCroock
commented
Mar 11, 2021
JoviDeCroock
commented
Mar 11, 2021
JoviDeCroock
commented
Mar 11, 2021
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
| @@ -19,8 +19,8 @@ const UPDATE = (state, url, push) => { | |||
| }; | |||
|
|
|||
| export const exec = (url, route, matches) => { | |||
| url = url.trim('/').split('/'); | |||
| route = (route || '').trim('/').split('/'); | |||
| url = url.split('/').filter(Boolean); | |||
There was a problem hiding this comment.
Just checked because I was curious: The issue is that trim() has no arguments and only trims whitespace. So the original code was wrong to begin with.
marvinhagemeister
approved these changes
Mar 14, 2021
developit
reviewed
Mar 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
Fixes #414