-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[preact-iso] Router should ignore links with target=".." #493
Conversation
🦋 Changeset detectedLatest commit: d04eee1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sounds good. Although ... come to think of it, the static SSR prerender probably needs to be tweaked as well, otherwise the links will be discovered and their target href generated on-disk. |
@danielweck good point! It ignores external URLs right now, but it should likely also be made to ignore non-self targeted links to match this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That test is superb
This prevents the Router's link handling from intercepting clicks on links with
<a target="anything">
. Only these cases will be intercepted:Fixes #488.