Fix assets referenced in CSS not copied in prod builds #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18b8f00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marvinhagemeister
force-pushed
the
css-assets
branch
2 times, most recently
from
8fcbe3a
to
39faab6
Compare
|
Size Change: +325 B (0%) Total Size: 736 kB
ℹ️ View Unchanged
|
marvinhagemeister
force-pushed
the
css-assets
branch
from
39faab6
to
d1635db
Compare
developit
reviewed
May 1, 2021
Comment on lines
135
to
+141
| source = transformCss(source); | ||
| } | ||
|
|
||
| // Note: `plugin.generateBundle` is only called during prod builds for | ||
| // CSS files. So we need to guard the url replacement code. | ||
| if (production) { | ||
| source = await transformCssImports(source, idRelative, { |
There was a problem hiding this comment.
reminder for myself: would be cool to implement transformCssImports within the transformCss pass so that it can use the Stylis AST.
There was a problem hiding this comment.
@developit the middlewares in stylis are expected to be synchronous, but our resolution mechanism is async. I'm not sure how we could avoid parsing the CSS twice with that restriction.
There was a problem hiding this comment.
Ah good point. It would have to be two-pass, which would be less than ideal.
marvinhagemeister
force-pushed
the
css-assets
branch
from
d1635db
to
7eb0e5a
Compare
JoviDeCroock
approved these changes
May 2, 2021
marvinhagemeister
force-pushed
the
css-assets
branch
from
7eb0e5a
to
18b8f00
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an asset is referenced in a CSS file we didn't copy the files over to our output directory.