Skip to content

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 5, 2022

This updates Button stories to match out new formatting, but also sets up e2e tests for this upcoming PR: #2652

This should only impact Storybook and e2e tests.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@langermank langermank requested review from a team and mperrotti December 5, 2022 23:34
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 0fa578f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank added the skip changeset This change does not need a changelog label Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 82.75 KB (0%)
dist/browser.umd.js 83.4 KB (0%)

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 5, 2022
@langermank langermank temporarily deployed to github-pages December 5, 2022 23:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 5, 2022 23:42 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 5, 2022
@langermank langermank temporarily deployed to github-pages December 5, 2022 23:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 5, 2022 23:53 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 5, 2022
@langermank langermank temporarily deployed to github-pages December 5, 2022 23:59 Inactive
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 5, 2022
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 5, 2022 23:59 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Dec 6, 2022
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 6, 2022
@primer primer bot temporarily deployed to github-pages December 6, 2022 00:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 6, 2022 00:18 Inactive
@langermank langermank temporarily deployed to github-pages December 6, 2022 19:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 6, 2022 19:12 Inactive
@langermank langermank temporarily deployed to github-pages December 6, 2022 20:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 6, 2022 20:14 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, do we also need to update the storybook URL in Button.mdx or will that end up in the same place? (Wasn't sure about the URL changes with the new stories)

@langermank langermank temporarily deployed to github-pages December 6, 2022 20:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2653 December 6, 2022 20:19 Inactive
@langermank
Copy link
Contributor Author

Quick question, do we also need to update the storybook URL in Button.mdx or will that end up in the same place? (Wasn't sure about the URL changes with the new stories)

Ahh yuuuup! Totally forgot 😅 done! Thank you 🙌

@langermank langermank merged commit 5551fdd into main Dec 6, 2022
@langermank langermank deleted the button-stories branch December 6, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants