Fixes for review

Author: grphil

clients/tsapi/masterstatus/master_status.go

@@ -45,9 +45,9 @@ func (s *MasterStatus) runUpdateThread() {
 
 	t := time.Tick(s.statusUpdateInterval)
 	for {
+		s.updateStatus()
 		select {
 		case <-t:
-			s.updateStatus()
 		}
 	}
 }
@@ -122,9 +122,7 @@ type SubmissionsFilter struct {
 func (s *MasterStatus) GetSubmissions(ctx context.Context, filter *SubmissionsFilter) ([]SubmissionInList, error) {
 	request := s.base.DB.
 		WithContext(ctx).
-		Model(&models.Submission{}).
-		Limit(filter.Count).
-		Offset((filter.Page - 1) * filter.Count)
+		Model(&models.Submission{})
 
 	if filter.ProblemID != nil {
 		request = request.Where("problem_id=?", *filter.ProblemID)
@@ -139,6 +137,8 @@ func (s *MasterStatus) GetSubmissions(ctx context.Context, filter *SubmissionsFi
 
 	err := request.
 		Order("id desc").
+		Limit(filter.Count).
+		Offset((filter.Page - 1) * filter.Count).
 		Find(&submissions).
 		Error
 

clients/tsapi/problem.go

@@ -29,12 +29,20 @@ func (h *Handler) getProblems(c *gin.Context) {
 		return
 	}
 	var problems []problemInList
+	if filter.Count <= 0 {
+		respError(c, http.StatusBadRequest, "Count should be positive number")
+		return
+	}
+	if filter.Page <= 0 {
+		respError(c, http.StatusBadRequest, "Page should be positive number")
+		return
+	}
 	err := h.base.DB.
 		WithContext(c).
 		Model(&models.Problem{}).
+		Order("id desc").
 		Limit(filter.Count).
 		Offset((filter.Page - 1) * filter.Count).
-		Order("id desc").
 		Find(&problems).
 		Error
 	if err != nil {

invoker/threads_executor.go

@@ -47,6 +47,7 @@ func (e *threadsExecutor[Value]) stop() {
 
 	if e.closed {
 		logger.Warn("%s threads are already stopped, calling stop twice", e.name)
+		return
 	}
 	e.closed = true
 	e.cond.Broadcast()