Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add direct link editor <> fullscreen views? #208

Open
lmccart opened this issue Nov 23, 2016 · 4 comments
Open

add direct link editor <> fullscreen views? #208

lmccart opened this issue Nov 23, 2016 · 4 comments

Comments

@lmccart
Copy link
Member

lmccart commented Nov 23, 2016

The designs have a proposed toggle between full screen and "minimized" or editor view. This seems to be different than the direct link to the full screen version as we have it now. In this version, I think it's more like an overlay...the url stays the same, the canvas just pops bigger with a white overlay over the editor behind it.

10 web-editor-light-example-dropdown-nav-1024 1x

07 web-editor-full-view-small-canvas-1024 1x

08 web-editor-full-view-medium-canvas-1024 1x

09 web-editor-full-view-large-canvas1024 1x

The question is, does this seem useful, or is this redundant? I like the direct link to full screen view, but another option is to just have this open a new tab with the current full screen view with the /full/ url (no author info).

@shiffman
Copy link
Member

I've been noticing as students present in class that it would be convenient to have some sort of maximize/minimize for p5.js rendered sketch area and the code editor itself. What I see students do a lot is drag the middle bar all the way to the left and all the way to the right depending on what they want to highlight.

I like the idea of having these features on the editor page itself in addition to the separate "full" view, but don't feel confident in this opinion so am open to any and all ideas.

@catarak
Copy link
Member

catarak commented Jan 17, 2017

We discussed this, and decided that both the preview and the code editor should be able to be maximized. This could either be with the arrow icon above, or both the editor and the preview could have dropdown arrows. These maximizing/minimizing actions could also have keyboard shortcuts.

@catarak
Copy link
Member

catarak commented Jul 10, 2017

Design

screen shot 2017-07-10 at 5 35 19 pm

screen shot 2017-07-10 at 5 36 11 pm

The custom icons can be downloaded from Zeplin.

@bengrosser
Copy link

Is this ability to maximize a sketch directly from the code editor view still planned? It seems right now the only way to quickly view a sketch in full screen mode is to edit the URL in the location bar, changing sketches to full.

It would be great for students if they could easily switch back and forth from code view to full screen view. Going back to the code from the full screen view is possible from the <> button on the full screen view, but there's no easy way to go the other direction.

@catarak catarak mentioned this issue Dec 6, 2019
1 task
@catarak catarak added this to Coding-writing experience in All Projects Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
All Projects
Code-writing experience
Development

No branches or pull requests

5 participants