Skip to content

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Aug 12, 2019

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@@ -0,0 +1,14 @@
import * as ActionTypes from '../../../constants';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a better name for this reducer/file is just 'search'

@catarak
Copy link
Member

catarak commented Aug 12, 2019

Screen Shot 2019-08-12 at 3 24 22 PM

Style changes:

  1. The border of the input should be the same as the input in the "Find" functionality
  2. The magnifying glass appears to not be centered—I think it's 1px too close too the top, and 1px too close to the left.

@catarak
Copy link
Member

catarak commented Aug 21, 2019

this looks so good and i think it's ready to be merged!

@catarak catarak merged commit 3d77973 into processing:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants