New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1487 #1490

Merged

catarak merged 1 commit into processing:develop from ghalestrilo:fix/mobile-crash-on-leave-preview

Jul 6, 2020

Collaborator

ghalestrilo commented Jul 3, 2020

Fixes #1487 by checking if the this.iframeElement.contentDocument.body element exists before unmounting it.

I have verified that this pull request:

has no linting errors (npm run lint)
is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
is descriptively named and links to an issue number, i.e. Fixes #123


          🐛 <PreviewFrame /> check for own iframe body tag before unmounting it

835a553

ghalestrilo requested a review from catarak

July 3, 2020 17:44

catarak merged commit 97c3b35 into processing:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment