Add <Console /> to Mobile Views #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged in #1503—do you want me to merge this in as is, or wait until you update with the new hooks API? |
|
This one can be merged - I'm refactoring it to hooks in another branch |
catarak
requested changes
Jul 20, 2020
3 tasks
catarak
requested changes
Jul 21, 2020
catarak
requested changes
Jul 21, 2020
…/p5.js-web-editor into feature/error-output
catarak
approved these changes
Jul 21, 2020
|
Looks great to me ✨ This can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1496 and #1497
Part of the Mobile UI project. Adds the
<Console />component to<MobileIDEView />and<MobileSketchView />. Transforms<Console />into a containerI have verified that this pull request:
npm run lint)Fixes #123