Initial setup for adding Hindi to the editor. #1703

abhieshekumar · 2020-12-05T12:22:38Z

Initial setup for adding Hindi to the editor #1701

I have verified that this pull request:

[✓] has no linting errors (npm run lint)
[✓] is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
[✓] is descriptively named and links to an ongoing issue #1701

The file does not contain any translated strings as of now. The strings will be added over the course of time.

catarak · 2020-12-07T17:57:29Z

I'd prefer to merge this in with the Hindi translation done, rather than just the setup completed.

abhieshekumar · 2020-12-07T20:27:56Z

Sure thing. Working on that.

translations/locales/hi/translations.json

catarak · 2021-01-05T20:25:10Z

@rt1301 I merged your changes to here! I'm going to close your other PR.

abhieshekumar · 2021-01-05T20:46:15Z

@catarak I have fixed the requested changes. Take a look.

catarak · 2021-01-06T17:53:10Z

Thank you @abhieshekumar! Everything looks good code-wise, so I'm going to solicit some feedback on this translation as you have requested 😄

translations/locales/hi/translations.json

saRvaGnyA · 2021-01-07T12:29:17Z

translations/locales/hi/translations.json

+        "Title": "मदद",
+        "KeyboardShortcuts": "कीबोर्ड शॉर्टकट",
+        "Reference": "रिफरेन्स",
+        "About": "के बारे में"


"About": "अधिक जान्कारी"

के बारे में looks incomplete

saRvaGnyA · 2021-01-07T12:32:29Z

translations/locales/hi/translations.json

+      "SignUp": "साइन अप",
+      "Auth": {
+        "Welcome": "स्वागत है",
+        "Hello": "नमस्कार",


"Hello": "नमस्ते",

नमस्कार is the action of greeting while नमस्ते is the greeting itself, so नमस्ते would seem more appropriate

saRvaGnyA · 2021-01-07T12:43:55Z

translations/locales/hi/translations.json

+      "Connect": "कनेक्ट {{serviceauth}} अकाउंट",
+      "Unlink": "अनलिंक {{serviceauth}} अकाउंट",
+      "Login": "{{serviceauth}} से लोगिन करें",
+      "LogoARIA": "{{serviceauth}} प्रतीक चिन्ह"


"LogoARIA": "{{serviceauth}} प्र्‌‍‌तिक‍ चिन्ह"

saRvaGnyA · 2021-01-07T12:45:44Z

translations/locales/hi/translations.json

+      "NewP5": "p5.js पर नये?",
+      "Report": "बग रिपोर्ट",
+      "Learn": "सीखें",
+      "Resources": "रीसॉर्सेज़",


"Resources": "साधन",

Phonetic translation for the technical term "Resources" was not matching. Here, a translation(like in the case of the word "Example") would be more appropriate.

I was looking for a better word for this translation. Thanks.

saRvaGnyA · 2021-01-07T12:52:13Z

translations/locales/hi/translations.json

+    },
+    "Toolbar": {
+      "Preview": "पूर्वावलोकन",
+      "Auto-refresh": "स्वयं रिफ़्रेश",


"Auto-refresh": "ऑटो-रिफ़्रेश",

saRvaGnyA · 2021-01-07T12:55:32Z

translations/locales/hi/translations.json

+      "PlaySketchARIA": "स्केच चलाएं",
+      "PlayOnlyVisualSketchARIA": "केवल दृश्य स्केच चलाएं",
+      "StopSketchARIA": "स्केच बंद करे",
+      "EditSketchARIA": "स्केच नाम संपादित करें",


"EditSketchARIA": "स्केच का नाम संपादित करें",

saRvaGnyA · 2021-01-07T12:57:48Z

Respected Ma'am @catarak, I saw the call for review for this pull request on Processing Forums.
@abhieshekumar, terrific work on the translation buddy!

I viewed all the translations and most of them are correct. However, there are some improvements I wanted to suggest.
I've added relevant single-line comments to the required lines of the commits too.

A major improvement I would like to suggest is wherever you have translated the word "Stop" as "बंद", please change it to "रोके". बंद literally means "to close" while रोके means "to stop".

saRvaGnyA · 2021-01-07T13:14:43Z

translations/locales/hi/translations.json

+      "SublimeText": "Sublime Text शॉर्टकट",
+      "CodeEditing": {
+        "Tidy": "साफ",
+        "FindText": "शब्द ढूंढना",


"FindText": "शब्द ढूंढे",

saRvaGnyA · 2021-01-07T13:20:00Z

translations/locales/hi/translations.json

+      },
+      "General": {
+        "StartSketch": "स्केच शुरू करें",
+        "StopSketch": "स्केच बंद करो",


"StopSketch": "स्केच रोके",

saRvaGnyA · 2021-01-07T13:34:22Z

translations/locales/hi/translations.json

+    },
+    "MobileIDEView":{
+      "Preferences": "प्राथमिकता",
+      "MyStuff": "मेरा स्टफ",


"MyStuff": "मेरे वस्तु",
मेरा स्टफ sounds pretty odd

saRvaGnyA · 2021-01-07T13:37:16Z

translations/locales/hi/translations.json

+      "NoCollections": "कोई संग्रह नहीं"
+    },
+    "Editor": {
+      "OpenSketchARIA": "स्केच फ़ाइलों का नेविगेशन खोलें",


"OpenSketchARIA": "स्केच फ़ाइलों का नॅविगेशन खोलें",

saRvaGnyA · 2021-01-07T13:38:57Z

translations/locales/hi/translations.json

+    },
+    "Editor": {
+      "OpenSketchARIA": "स्केच फ़ाइलों का नेविगेशन खोलें",
+      "CloseSketchARIA": "स्केच फ़ाइलों का नेविगेशन बंद करें",


"CloseSketchARIA": "स्केच फ़ाइलों का नॅविगेशन बंद करें",

saRvaGnyA · 2021-01-07T13:39:57Z

translations/locales/hi/translations.json

+      "KeyUpLineNumber": "लाइन {{lineNumber}}"
+    },
+    "EditorAccessibility": {
+      "NoLintMessages": "कोई लिंट मैसिज नहीं ",


"NoLintMessages": "कोई लिंट मैसेज नहीं ",

saRvaGnyA · 2021-01-07T13:44:09Z

translations/locales/hi/translations.json

+    },
+    "EmailVerificationView": {
+      "Title": "p5.js वेब एडिटर | ईमेल वेरीफिकेशन",
+      "Verify": "अपना ईमेल वेरफाइ करें",


"Verify": "अपना ईमेल व्हॅरीफाय करें",

catarak · 2021-01-07T19:55:36Z

Thanks for your suggestions @saRvaGnyA! @abhieshekumar you are welcome to accept these suggestions or decide they don't make sense to you, and let me know if I can support you in these decisions!

abhieshekumar · 2021-01-27T00:35:30Z

@catarak I have made the suitable changes. Thanks @saRvaGnyA.

catarak · 2021-01-29T20:39:48Z

Thank you for making these changes! I'm going to go ahead and merge this ✨ To be deployed soon!

abhieshekumar added 3 commits December 5, 2020 16:59

[processing#1701] Add Hindi support to the file.

6232817

[processing#1701] Add language option in dropdown.

7205ff4

[processing#1701] Add translation file for hindi.

c5f95d8

The file does not contain any translated strings as of now. The strings will be added over the course of time.

abhieshekumar changed the title ~~Initial setup for adding Hindi to the editor #1701.~~ Initial setup for adding Hindi to the editor. Dec 5, 2020

abhieshekumar and others added 7 commits December 15, 2020 19:19

Transalation underway

a1ad8f6

Added more translations.

cc27433

Feat:Added Hindi Translations

942b689

Added a few more translations

c6ba35d

Added more hindi translations

3fc9040

Fixed es-lint err

f1fb63b

Added all translations

23f057c

abhieshekumar mentioned this pull request Jan 3, 2021

Adding Hindi as a part of i18n. #1701

Closed

catarak added 2 commits January 5, 2021 15:20

Merge Hindi translations

062791f

Merge branch 'develop' into i18n-hindi

26858dc

catarak requested changes Jan 5, 2021

View reviewed changes

translations/locales/hi/translations.json Outdated Show resolved Hide resolved

translations/locales/hi/translations.json Outdated Show resolved Hide resolved

translations/locales/hi/translations.json Show resolved Hide resolved

catarak mentioned this pull request Jan 5, 2021

#1701- Hindi Translations #1723

Closed

3 tasks

Fixed requested changes

57978d9

saRvaGnyA reviewed Jan 7, 2021

View reviewed changes

translations/locales/hi/translations.json Outdated Show resolved Hide resolved

saRvaGnyA reviewed Jan 7, 2021

View reviewed changes

translations/locales/hi/translations.json Outdated Show resolved Hide resolved

saRvaGnyA reviewed Jan 7, 2021

View reviewed changes

Incorporated review changes

10935e8

Merge develop

02d77df

catarak approved these changes Jan 29, 2021

View reviewed changes

catarak merged commit d7224b8 into processing:develop Jan 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial setup for adding Hindi to the editor. #1703

Initial setup for adding Hindi to the editor. #1703

abhieshekumar commented Dec 5, 2020

catarak commented Dec 7, 2020

abhieshekumar commented Dec 7, 2020

catarak commented Jan 5, 2021

abhieshekumar commented Jan 5, 2021

catarak commented Jan 6, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021

abhieshekumar Jan 27, 2021

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA commented Jan 7, 2021

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

saRvaGnyA Jan 7, 2021

catarak commented Jan 7, 2021

abhieshekumar commented Jan 27, 2021 •

edited

catarak commented Jan 29, 2021

Initial setup for adding Hindi to the editor. #1703

Initial setup for adding Hindi to the editor. #1703

Conversation

abhieshekumar commented Dec 5, 2020

catarak commented Dec 7, 2020

abhieshekumar commented Dec 7, 2020

catarak commented Jan 5, 2021

abhieshekumar commented Jan 5, 2021

catarak commented Jan 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saRvaGnyA Jan 7, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saRvaGnyA Jan 7, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saRvaGnyA Jan 7, 2021 • edited

Choose a reason for hiding this comment

saRvaGnyA Jan 7, 2021 • edited

Choose a reason for hiding this comment

saRvaGnyA commented Jan 7, 2021

saRvaGnyA Jan 7, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catarak commented Jan 7, 2021

abhieshekumar commented Jan 27, 2021 • edited

catarak commented Jan 29, 2021

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021 •

edited

saRvaGnyA Jan 7, 2021 •

edited

abhieshekumar commented Jan 27, 2021 •

edited