Skip to content

[#1962] Ensure sketch is rendered in FullView #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

[#1962] Ensure sketch is rendered in FullView #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/modules/IDE/pages/FullView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,21 @@ import RootPage from '../../../components/RootPage';
function FullView(props) {
const dispatch = useDispatch();
const project = useSelector((state) => state.project);
const [isRendered, setIsRendered] = useState(false);

useEffect(() => {
dispatch(getProject(props.params.project_id, props.params.username));
}, []);

useEffect(() => {
// if (isRendered) prevents startSketch() from being called twice
// this calls startSketch if REGISTER happens before sketch is fetched
if (isRendered) {
dispatch(startSketch());
}
}, [project.id]);

// send register event until iframe is loaded and sends a message back.
const [isRendered, setIsRendered] = useState(false);
const clearInterval = useInterval(() => {
dispatchMessage({ type: MessageTypes.REGISTER });
}, 100);
Expand Down