Skip to content

Conversation

clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Sep 25, 2025

Rebuild of #3648 due to issues rebasing, no changes from that branch & have addressed later feedback

Changes:

  • Migrate /server/views files related to emailing
  • Migrate /server/utils/mail
  • Extract types to /server/types/email.ts from existing logic & nodemailer types

Other:

  • Took a look at /migrations/emailConsolidation, but this requires the User and Project models to be migrated first, which I'll do next

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@clairep94 clairep94 marked this pull request as ready for review September 25, 2025 22:11
@clairep94 clairep94 added the pr05 Grant Projects pr05 Grant Projects label Sep 25, 2025
@clairep94 clairep94 changed the title Pr05/migrate mail system pr05 Typescript Migration 12: Migrate server files related to emailing/nodemailer -- REBUILD Sep 25, 2025
@clairep94
Copy link
Collaborator Author

@khanniie @raclim
I rebuilt this bc I did something funny on my branch trying to merge develop into it. this is an exact rebuild of that branch, having addressed the final feedback

Copy link
Member

@khanniie khanniie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!!

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, will merge this in!

@raclim raclim merged commit f98e7d6 into develop Sep 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr05 Grant Projects pr05 Grant Projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants