Respect example username setting #648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 8, 2018 13:56
… details specified in .env file
Add the server-side process.env.EXAMPLE_USERNAME variable to the webpack.DefinePlugin declaration so that it can be accessed client-side. Make use of this in Nav.jsx so that examples are retrieved from the actual example user.
3 tasks
shinytang6
reviewed
Jun 8, 2018
| @@ -217,7 +217,7 @@ class Nav extends React.PureComponent { | |||
| </li> } | |||
| <li className="nav__dropdown-item"> | |||
| <Link | |||
| to="/p5/sketches" | |||
| to={`/${process.env.EXAMPLE_USERNAME}/sketches`} | |||
There was a problem hiding this comment.
l know this works fine in the development env:) but l don't know if it works in the production env
|
hey @awarua, i put some of my thoughts about this in #646. let me know what you think! |
|
Closing this because it is better addressed by #651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before your pull request is reviewed and merged, please ensure that:
there are no linting errors --
npm run lint(There are linting errors, but not from any of the files I have touched. Do you still want me to fix these?).your code is in a uniquely-named feature branch and has been rebased on top of the latest master. If you're asked to make more changes, make sure you rebase onto master then too!
your pull request is descriptively named and links to an issue number, i.e.
Fixes #646This pull request addresses Issue #646. It improves the wording of the readme to clarify that the example user will be created with whatever username is provided in the
.envfile and also uses this value in the code. Previously, several locations in the code used a hard-coded value of "p5" for the example user.I am an absolute novice with node and react, so please check that what I've done is sensible!