Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a style guide for documentation. Addresses #6178 #6206

Merged
merged 3 commits into from Jun 15, 2023
Merged

Add a style guide for documentation. Addresses #6178 #6206

merged 3 commits into from Jun 15, 2023

Conversation

nickmcintyre
Copy link
Member

Addresses #6178

Changes:

I drafted a style guide for documentation in contributor_docs/documentation_style_guide.md and would love to incorporate suggestions.

Should I open a separate PR for examples of edited documentation?

@wong-justin @aferriss @aceslowman would the proposed style guide suit your needs for WebGL documentation?

What are people's thoughts about requiring describe() throughout the documentation? Two possibilities come to mind:

  • Require describe() in all Examples and Reference code samples
  • Require describe() in all Examples

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, it looks good to me! I added a few notes that don't require any changes here but are just things we might want to be aware of when considering the rest of the docs.

contributor_docs/documentation_style_guide.md Show resolved Hide resolved
contributor_docs/documentation_style_guide.md Show resolved Hide resolved
contributor_docs/documentation_style_guide.md Show resolved Hide resolved
contributor_docs/documentation_style_guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Qianqianye Qianqianye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing such a comprehensive style guide! I added a few comments, mostly in the 'accessibility' session.

@aceslowman
Copy link
Contributor

would the proposed style guide suit your needs for WebGL documentation?

I think so! This should be a really helpful document for new contributors. One question that came up for me, would it be helpful to address how to handle assets in documentation and reference examples? This is something I've been unsure of in the past as a contributor and might save someone from doing guesswork, from what I understand, assets are stored in:

Examples: src/data/examples/assets
Reference Pages: src/templates/pages/reference/assets
Learn Pages: src/assets/learn

Also, it might be worth noting that local assets would be preferable to external ones.

@nickmcintyre
Copy link
Member Author

@aceslowman great suggestion. I'll draft a guideline for including paths in the form 'assets/file.xyz'. It will include a note on where to place those assets for different types of documentation.

@nickmcintyre nickmcintyre merged commit 2222f52 into processing:main Jun 15, 2023
5 checks passed
@nickmcintyre nickmcintyre deleted the docs-style-guide branch June 15, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants