move PApplet from Activity to Fragment #118
Conversation
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Signed-off-by: Umair Khan <omerjerk@gmail.com>
Conflicts: src/processing/mode/android/Manifest.java
| @@ -854,9 +861,72 @@ private File mkdirs(final File parent, final String name) throws SketchException | |||
| } | |||
| return result; | |||
| } | |||
|
|
|||
|
|
|||
| private void writeMainActivity(final File srcDirectory) { | |||
There was a problem hiding this comment.
This should be read from a file. It's too much code to be writing from the PDE.
There was a problem hiding this comment.
I too think so.
I'll make the appropriate changes.
There was a problem hiding this comment.
@benfry
What do you think should be the appropriate location for this file (MainActivity.java) ?
I would also like to point out that build.xml is also written by the PDE itself and is around twice the size of MainActivity.java. See - https://github.com/processing/processing-android/blob/master/src/processing/mode/android/AndroidBuild.java#L617
|
How do fragments relate to Android Wear and active wallpapers? Or are those entirely different things as well, and would need their own type of |
|
Our |
|
Ok, thanks. Memory just hazy on all those pieces. Given the changes in the desktop version and the addition of |
We're dropping the support for gingerbread devices Signed-off-by: Umair Khan <omerjerk@gmail.com>
|
I've removed the support library. |
|
Hi Umair, there are some conflicts between this pull request, and the latest revision in master. Can you take a look and update the modifications? |
|
Sure. Solving the conflicts. |
Conflicts: src/processing/mode/android/AndroidBuild.java
move PApplet from Activity to Fragment
No description provided.