Remove premultiplyMatrices and ellipseDetailMultiplier #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should simplify the code and remove some boilerplate, as discussed here processing/processing#5256 (comment) I have tested this and it doesn't seem to make a significant performance difference my benchmarks. However, a further optimization could be to cache all or part of the circleDetail() calculation when tessellating a line path, since (I think?) matrices either are assumed or can be proven not to change during that time.
|
@notnullnotvoid thank you, I will review these changes and include in the next bugfix release after 4.1, which I'm trying to push in the next few days. |
codeanticode
changed the base branch from
android-0276-v4.1.0
to
android-0277-v4.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should simplify the code and remove some boilerplate, as discussed here processing/processing#5256 (comment)
I have tested this and it doesn't seem to make a significant performance difference in my benchmarks. However, a further optimization could be to cache all or part of the circleDetail() calculation when tessellating a line path, since (I think?) matrices either are assumed or can be proven not to change during that time.