Fix for Android Export Project Issues #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranaaditya
approved these changes
Sep 7, 2023
|
Hi @codeanticode , i have reviewed this Pr, can you also check the changes once. This solves the #741 once you review it, I wil merge it then. Thanks, |
|
This is great, thanks for the PR @rupeshkumar22, and for the review @ranaaditya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
With this PR gradlew.zip file will get replaced with the new gradlew.zip file which includes gradle-wrapper.jar which is required in case we run a gradlew command otherwise it shows error.
Also, remove root is set to false so that the wrapper folder must be generated properly inside the gradle folder inside the root folder.
The newly added gradlew.zip file is zipped with the files generated in an exported project with the gradle wrapper command-
gradle wrapper --gradle-version 7.4.1 --distribution-type allMore information for the above command is mentioned on the official pages.
Existing Structure of Exported Project-
Root->wrapper->gradle-wrapper.propertiesStructure of Exported Project after applying changes-
Root->gradle->wrapper->gradle-wrapper.propertiesRoot->gradle->wrapper->gradle-wrapper.jarTo verify the changes
gradlew assembleDebugcommand was executed in exported project directory and the build was successful.@ranaaditya @codeanticode Could you please review? Let me know in case any information is required.
Thanks,
Rupesh