Support for windows surfaces. (#1310)

Author: tychedelia

core/src/processing/core/NativeLibrary.java

@@ -82,7 +82,9 @@ public static String getPlatform() {
      */
     private static void loadNativeLibrary() throws IOException {
         String platformTarget = platform + "-" + architecture;
-        String libraryFileName = "lib" + LIBRARY_NAME + "." + libraryExtension;
+        String libraryFileName = platform.equals("windows")
+            ? LIBRARY_NAME + "." + libraryExtension
+            : "lib" + LIBRARY_NAME + "." + libraryExtension;
         String resourcePath = "/native/" + platformTarget + "/" + libraryFileName;
 
         // check classloader for resource in jar

core/src/processing/webgpu/PSurfaceGLFW.java

@@ -4,6 +4,7 @@
 import org.lwjgl.glfw.GLFWErrorCallback;
 import org.lwjgl.glfw.GLFWFramebufferSizeCallback;
 import org.lwjgl.glfw.GLFWNativeCocoa;
+import org.lwjgl.glfw.GLFWNativeWin32;
 import org.lwjgl.glfw.GLFWWindowPosCallback;
 import org.lwjgl.system.MemoryUtil;
 import org.lwjgl.system.Platform;
@@ -120,6 +121,8 @@ public Object getNative() {
     public long getWindowHandle() {
         if (Platform.get() == Platform.MACOSX) {
             return GLFWNativeCocoa.glfwGetCocoaWindow(window);
+        } else if (Platform.get() == Platform.WINDOWS) {
+            return GLFWNativeWin32.glfwGetWin32Window(window);
         } else {
             throw new UnsupportedOperationException("Window handle retrieval not implemented for this platform");
         }

libProcessing/Cargo.lock

@@ -12,4 +12,7 @@ raw-window-handle = "0.6"
 
 [target.'cfg(target_os = "macos")'.dependencies]
 objc2 = { version = "0.6", default-features = false }
-objc2-app-kit = { version = "0.3", features = ["NSWindow", "NSView"] }
+objc2-app-kit = { version = "0.3", features = ["NSWindow", "NSView"] }
+
+[target.'cfg(target_os = "windows")'.dependencies]
+windows = { version = "0.58", features = ["Win32_Foundation", "Win32_System_LibraryLoader"] }

libProcessing/renderer/Cargo.toml

@@ -131,8 +131,41 @@ pub fn create_surface(
     };
 
     #[cfg(target_os = "windows")]
-    let (raw_window_handle, raw_display_handle) =
-        { todo!("implemnt windows raw window handle conversion") };
+    let (raw_window_handle, raw_display_handle) = {
+        use raw_window_handle::{Win32WindowHandle, WindowsDisplayHandle};
+        use std::num::NonZeroIsize;
+        use windows::Win32::Foundation::HINSTANCE;
+        use windows::Win32::System::LibraryLoader::GetModuleHandleW;
+
+        if window_handle == 0 {
+            return Err(error::ProcessingError::InvalidWindowHandle);
+        }
+
+        // HWND is isize, so cast it
+        let hwnd_isize = window_handle as isize;
+        let hwnd_nonzero = match NonZeroIsize::new(hwnd_isize) {
+            Some(nz) => nz,
+            None => return Err(error::ProcessingError::InvalidWindowHandle),
+        };
+
+        let mut window = Win32WindowHandle::new(hwnd_nonzero);
+
+        // VK_KHR_win32_surface requires hinstance *and* hwnd
+        // SAFETY: GetModuleHandleW(NULL) is safe
+        let hinstance = unsafe { GetModuleHandleW(None) }
+            .map_err(|_| error::ProcessingError::InvalidWindowHandle)?;
+
+        let hinstance_nonzero = NonZeroIsize::new(hinstance.0 as isize)
+            .ok_or(error::ProcessingError::InvalidWindowHandle)?;
+        window.hinstance = Some(hinstance_nonzero);
+
+        let display = WindowsDisplayHandle::new();
+
+        (
+            RawWindowHandle::Win32(window),
+            RawDisplayHandle::Windows(display),
+        )
+    };
 
     #[cfg(target_os = "linux")]
     let (raw_window_handle, raw_display_handle) =