Skip to content

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented May 20, 2018

Change repo to repo.rb for commit messages to correspond.

Closes #231.

Change repo to repo.rb for commit messages to correspond.
@dunxen dunxen changed the title change repo to repo.rb Change repo to repo.rb, update reset-squash-r3.png May 20, 2018
@dunxen
Copy link
Contributor Author

dunxen commented May 20, 2018

This should also complete PR #231.
If you would like me to also export diagram source as SVG I can do that too.

@ben
Copy link
Member

ben commented May 21, 2018

If you would like me to also export diagram source as SVG I can do that too.

That would be awesome, actually. Sketch worked well for us when developing the diagrams, but maintaining them is a job better left to SVG. That's a separate PR, however.

For this one, I just see one issue: the exported image size. Since we're not printing these, we're trying to keep the e-book versions a manageable file size, so can you shrink to the old dimensions and run pngcrush?

image

@dunxen
Copy link
Contributor Author

dunxen commented May 21, 2018

Hey!

Yeah I’ll do that as soon as I get to the office in the morning (accidentally left my laptop there). Then I'll rebase and push. Sorry about that!

I’ll do a separate PR for the SVG source after that!

dunxen added 2 commits May 22, 2018 09:28
Updates the change made to the bottom head in reset-squash-r3.png.
(commit abf9379)
@ben ben merged commit 1eff741 into progit:master Aug 26, 2018
@ben
Copy link
Member

ben commented Aug 26, 2018

Sorry for the delay, thanks!

@jnavila jnavila added the translation backport Tags a PR for translators to backport in their own repo label Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation backport Tags a PR for translators to backport in their own repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants