Make some stylistic tweaks to Chapter 1, Introduction #1072
Conversation
Stylistic/aesthetic adjustments, including: - use "--" for em-style dashes, not special characters - remove superfluous Oxford comma - add some commas where they're warranted - expand on the "git config" options Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Do we have a standard for this in the book? This is a change which could be ping-ponged between two groups of users until the end of time. |
|
I typically wouldn't submit a pull request for just that, but since there was other stuff being changed, I snuck it in. The standard I've seen (and used) for a while is that the Oxford comma is not used unless it actually clarifies the expression, which would be ambiguous otherwise. I like this explanation. But if Ben wants to toss it, he has my blessing. |
|
On 6/6/2018 9:12 AM, Robert P. J. Day wrote:
I typically wouldn't submit a pull request for just that, but since
there was other stuff being changed, I snuck it in. The standard I've
seen (and used) for a while is that the Oxford comma is not used unless
it actually clarifies the expression, which would be ambiguous
otherwise. I like this explanation
<https://en.oxforddictionaries.com/explore/what-is-the-oxford-comma>.
But if Ben wants to toss it, he has my blessing.
I vote for consistency. Either the Oxford comment should always
be used, or it should never be used. If there is a case where
it's necessary for clarification then this is a good argument
for always using it.
Jon
|
| The next major issue that people encounter is that they need to collaborate with developers on other systems. | ||
| To deal with this problem, Centralized Version Control Systems (CVCSs) were developed. | ||
| These systems, such as CVS, Subversion, and Perforce, have a single server that contains all the versioned files, and a number of clients that check out files from that central place. (((CVS)))(((Subversion)))(((Perforce))) | ||
| These systems, such as CVS, Subversion and Perforce, have a single server that contains all the versioned files, and a number of clients that check out files from that central place. (((CVS)))(((Subversion)))(((Perforce))) |
There was a problem hiding this comment.
In this case, it seems like the liberal sprinkling of commas is doing us all a disservice. What if we repunctuate to something like this:
These systems (such as CVS, Subversion, and Perforce) have a single server that contains all the versioned files, and a number of clients that check out files from that central place.
That way it gets more readable AND I get to keep my Oxford comma. 😁
There was a problem hiding this comment.
I'm fine with whatever you decide. Tweak the pull request, I'm in the middle of more wide-sweeping changes. :-)
There was a problem hiding this comment.
Sadly I cannot push to your fork. :(
There was a problem hiding this comment.
OK, I'll resubmit with that change. (I thought I checked the box that lets you edit my pull requests, is that not what that means?)
There was a problem hiding this comment.
Ha, I was making that way harder than I needed to. 😊
Stylistic/aesthetic adjustments, including:
Signed-off-by: Robert P. J. Day rpjday@crashcourse.ca