Tree objects don't nec. point to trees #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> "A single tree object contains one or more tree entries" The language suggests that each tree object contains (at least one) reference to another tree object, which is wrong.
ben
reviewed
Jul 13, 2018
| Git stores content in a manner similar to a UNIX filesystem, but a bit simplified. | ||
| All the content is stored as tree and blob objects, with trees corresponding to UNIX directory entries and blobs corresponding more or less to inodes or file contents. | ||
| A single tree object contains one or more tree entries, each of which contains a SHA-1 pointer to a blob or subtree with its associated mode, type, and filename. | ||
| A single tree object contains one or more entries, each containing a SHA-1 pointer to a blob or subtree with its associated mode, type, and filename. |
There was a problem hiding this comment.
How about "…each of which is the SHA-1 hash of a blob or subtree…"
There was a problem hiding this comment.
Some options (bolding wouldn't go in):
-
A single tree object contains one or more tree entries, each of which is the SHA-1 hash of a blob or subtree with its associated mode, type, and filename.
-
A single tree object contains one or more entries, each of which is the SHA-1 hash of a blob or subtree with its associated mode, type, and filename.
-
[no change to original copy]
-
[pull request]
I'd be happy with any. I think you're suggesting 2?
There was a problem hiding this comment.
Yeah, 2 seems like the most correct.
|
✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language suggests that each tree object contains (at least one) reference to another tree object, which is wrong.