Fixed the author name #1102
Merged
Fixed the author name #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the section 2.3, if one wants to see the changes made by the author Junio Hamano, the author name cannot be gitster. Fixed the same.
ben
reviewed
Aug 15, 2018
| [source,console] | ||
| ---- | ||
| $ git log --pretty="%h - %s" --author=gitster --since="2008-10-01" \ | ||
| $ git log --pretty="%h - %s" --author=Junio Hamano --since="2008-10-01" \ |
There was a problem hiding this comment.
Probably this should be --author='Junio Hamano'.
There was a problem hiding this comment.
It works without quotes; at least for me :)
There was a problem hiding this comment.
$ git log --pretty="%h - %s" --author=Junio Hamano --since="2008-10-01"
fatal: ambiguous argument 'Hamano': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
In any case, even if it works in some places, we should follow good practices and wrap arguments in quotes.
Also:
$ git log --pretty="%h - %s" --author='Junio Hamano' --since="2008-10-01" | wc -l
2
Looks like Junio signs his commits as Junio C Hamano most of the time. Can you fix that as well?
In the section 2.3, if one wants to see the changes made by the author Junio C Hamano, the author name cannot be gitster. Fixed the same.
|
@ben Done. I think it is safe to merge now. |
|
🌈 |
jnavila
added
the
translation backport
aollier
added a commit
to aollier/progit2-fr
that referenced
this pull request
Oct 31, 2018
gitster est l'identifiant de Junio C Hamano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the section 2.3, if one wants to see the changes made by the author
Junio Hamano, the author name cannot be gitster. Fixed the same.