Skip to content

Conversation

tfiers
Copy link
Contributor

@tfiers tfiers commented Aug 28, 2020

Implementation of #1506 (comment)

@tfiers
Copy link
Contributor Author

tfiers commented Aug 28, 2020

Alright, offending line in build from #1506 (comment) is gone now.

To really understand the way Git does branching, we need to take a step back and examine how Git stores its data.

As you may remember from <<ch01-getting-started#_what_is_git>>, Git doesn't store data as a series of changesets or differences, but instead as a series of _snapshots_.
As you may remember from <<ch01-getting-started#section__what_is_git>>, Git doesn't store data as a series of changesets or differences, but instead as a series of _snapshots_.

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I meant to use 2 underscores to distinguish the 'type' from the 'identifier'.

But good catch with the other ID; I'll change it to be consistent (but then without a leading underscore); i.e. what_is_git_section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnavila what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not purist, but just being consistent is great.

@jnavila
Copy link
Member

jnavila commented Aug 28, 2020

local test:
image

@ben
Copy link
Member

ben commented Aug 28, 2020

Everybody happy here? I'm ready to merge.

@ben ben merged commit fdb68d7 into progit:master Aug 28, 2020
@tfiers
Copy link
Contributor Author

tfiers commented Aug 28, 2020

Thanks all for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants