Add caution: don't amend pushed commits #1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
I think we should be more explicit about
git commit --amend
being a good thing for commits that have not been pushed, but potentially problematic for commits that have been pushed already, as that alters the history for everybody who pulls the branch again.Or do you want me to improve the [NOTE] block that's just above my newly created [CAUTION] block? Maybe having two blocks of warnings is a bit excessive?