Skip to content

Conversation

Sophismata
Copy link
Contributor

@Sophismata Sophismata commented Oct 5, 2020

Changes

  • Removed the erroneous --add parameter from the example core.editor config used for TextEdit.

Context

Fixes #1537

Removed the erroneous --add parameter from the example core.editor config used for TextEdit.
@Sophismata
Copy link
Contributor Author

Apologies; I wanted to make a quick PR but goofed it up. This is the correction for issue #1537, but when I attempted to fix the branch name of my first PR I mucked up the naming a second time.

@HonkingGoose
Copy link
Contributor

Thanks for contributing!

I always goof up changing the branch name as well! 😄 It's way too easy to miss changing the default Username-patch-x branch name, don't feel bad about that. 👍

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@Sophismata
Copy link
Contributor Author

Thanks! Sorry for the late reply, I've been absolutely smashed at work and only just checked my notifications today. Do you need me to do anything further?

@HonkingGoose
Copy link
Contributor

Hi @Sophismata, thanks for adding the suggestion. I don't need you to do anything more. 😉

@ben I think this is ready for your review and merge.

@ben
Copy link
Member

ben commented Nov 12, 2020

@ben ben merged commit 6c25f58 into progit:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appendix C: core.editor command for TextEdit incorrectly uses --add
3 participants