resolves #1671 install Kindlegen so .mobi output can be produced #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slonopotamus
commented
Jun 29, 2021
slonopotamus
commented
- I provide my work under the project license.
- I grant such license of my work as is required for the purposes of future print editions to Ben Straub and Scott Chacon.
This comment has been minimized.
This comment has been minimized.
|
Whoops. Fixed. |
HonkingGoose
suggested changes
Jun 29, 2021
Benefits: 1. Command is printed to stdout, so it is clear what is being executed 2. Whole build will fail if any command fails
|
I'd say this is ready for review by @ben now. 😉 |
|
✨ |
|
That seems to have done the trick, we're publishing Thank you very, very, very much @slonopotamus for your hard work on getting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.