Formatting and characters #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smart quotes (“”) -> " Em-dash (—) -> en-dash (–)
|
I went ahead and pushed that re-wrapping change. Like I said, if you hate it I'll drop it. |
|
Merging for now. If you hate the wrapping, I'll clean it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this out of the way, since it adds a lot of noise to other PRs.
That last point will pretty much make any diffs from before and after this PR incompatible, as well as making this PR nearly un-reviewable, but I think it'll make life better further on. If you hate the idea, I won't do it.
For now I'm avoiding chapters
2, 3, and10, since it's covered by #28, but if that gets merged before this does, I'll roll it in too.