Small fixes #521
Small fixes #521
Conversation
Although Vim uses files that end with '~', usually 'git status' shows '.*.swp' file that is present during editing a file (~ file is present only at saving time)
I think it is better to warn reader that commit/tag hashes in 10th chapter are different from what he/she will get. Other hashes (of blobs and trees) are identical so reader can think that he has done something wrong
* We need 'git checkout master' because we've left on 'test' branch in previous section * I was surprised that before gc we had only 22K objects, because we have two copies of 22K files. So I checked it and it appears that because of compression each of them takes only 7K place on disk. Also before compression all objects take 15K if summing them up (not 22K).
| fdf4fc3344e67ab068f836878b6c4951e3b15f3d | ||
| ---- | ||
|
|
||
| You will get another hash value because of different creation time and author data. |
There was a problem hiding this comment.
Instead of "another", can you use "a different"? I initially read this as "you'll get a second hash value."
|
Nice! Thanks! |
| You've cut your disk usage by ⅔ by packing your objects. | ||
| What is cool is that although the objects on disk before you ran the `gc` were collectively about 15K in size, the new packfile is only 7K. | ||
| You've cut your disk usage by ½ by packing your objects. | ||
|
|
There was a problem hiding this comment.
Just a record: 2/3 -> 1/2 (Too small to read here)
There was a problem hiding this comment.
This is an intentional change. I've executed all commands in this chapter and measured sum size of all objects. It is 15K, not 22K. Probably author missed the fact that objects are compressed even when stored out of packfile...
I can provide script that executes all commands in this chapter till this line so that anyone can check my data.
@ben, maybe it would be better to just write "by half"?
There was a problem hiding this comment.
I checked the web page. It's good, not too small. 😄
There was a problem hiding this comment.
Yeah, "by half" is more idiomatic in English. You'd only use ½ for an exact fraction, and this isn't exact.
There was a problem hiding this comment.
Ok, I've created PR: #535
3 participants
I've put several small fixes to one PR, I hope this will save your time.
If it's better to make separate PRs for them - please tell me.