Skip to content

Conversation

YueLinHo
Copy link
Contributor

There is no git add remote, related command, or statement in previous sections, but git clone.
And the only remote repository mentioned is "origin" which is added automatically via clone command.
Fix the sentence for that.

Only one question: the words directly vs. explicitly. Which one is better?

@ben
Copy link
Member

ben commented Feb 17, 2016

Nice, but could I suggest a tweak?

The `clone` command implicitly adds the `origin` remote for you.
Here's how to add one explicitly.

@YueLinHo
Copy link
Contributor Author

@ben Excellent. 😃

@YueLinHo
Copy link
Contributor Author

Question: could you please tell me what (((git commands, remote))) means? I still can't figure it out. 😟

@jnavila
Copy link
Member

jnavila commented Feb 18, 2016

@YueLinHo this is just to insert an index entry reference at this place in the book. At the end of the book, there is a term index and you will find this reference under the index term "git commands", sub term "remote". This is present in the pdf only.

@YueLinHo
Copy link
Contributor Author

@jnavila Thank you so much. 😄

@YueLinHo
Copy link
Contributor Author

Rebased!


We've mentioned and given some demonstrations of adding remote repositories in previous sections, but here is how to do it explicitly.(((git commands, remote)))
We've mentioned and given some demonstrations of 'clone' command which implicitly adds the `origin` remote for you in previous sections.
Here's how to add one explicitly.(((git commands, remote)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close. How about this:

We've mentioned and given some demonstrations of how the `clone` command implicitly adds the `origin` remote for you.
Here's how to add a new remote explicitly.(((git commands, remote)))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's better. Nice!!!

…vious sections.

There is no `git add remote`, related command, or statement in previous sections, but `git clone`.
And the only remote repository mentioned is "origin" which is added implicitly via clone command.
Fix the sentence for that.
@YueLinHo
Copy link
Contributor Author

@ben I have rebased and updated this PR. Please review it, again. 😃

@ben
Copy link
Member

ben commented Feb 22, 2016

Nice. Thanks!

ben added a commit that referenced this pull request Feb 22, 2016
Fix issue #526: There is no *adding* remote repositories in previous sections.
@ben ben merged commit ad2b23b into progit:master Feb 22, 2016
@YueLinHo
Copy link
Contributor Author

@ben thank you. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants