Skip to content

Conversation

KennethKinLum
Copy link
Contributor

it really is a filename that ends with a ~, instead of a file that ends with a ~


The first line tells Git to ignore any files ending in ``.o'' or ``.a'' – object and archive files that may be the product of building your code.
The second line tells Git to ignore all files that end with a tilde (`~`), which is used by many text editors such as Emacs to mark temporary files.
The second line tells Git to ignore all files that end with a tilde (`~`) in the filename, which is used by many text editors such as Emacs to mark temporary files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we say "all files whose names end with a tilde"? I think that's slightly smoother.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... i changed and pushed... you think

If your preferred editor is Emacs or Vim, you know about files that end with a ~ or .swp in the filename.

will be

If your preferred editor is Emacs or Vim, you know about files whose names end with a ~ or .swp.

and

The second line tells Git to ignore all files that end with a tilde (~) in the filename, which is used by many text editors such as Emacs to mark temporary files.

to

The second line tells Git to ignore all files whose names end with a tilde (~), which is used by many text editors such as Emacs to mark temporary files.

... may sound repetitive, but they are in different sections of the book.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, those changes sound great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case seems like can directly mention the "filenames":

If your preferred editor is Emacs or Vim, you know about filenames that end with a ~ or .swp.

@ben
Copy link
Member

ben commented Feb 28, 2016

I like it. Do you feel like this is ready?

@KennethKinLum
Copy link
Contributor Author

Sure, they look good to me.

ben added a commit that referenced this pull request Feb 28, 2016
@ben ben merged commit 6f4d813 into progit:master Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants