Added a few changes to the "GitHub" chapter #710
Conversation
* corrected the first line of the chapter to prevent the over stress about GitHub * changed a sentence to make it read better * added "forking" to the GitHub workflow * retitled a section from "Markdown" to "GitHub Flavored Markdown" and reduced the level of sections under the latter section by 1 as, much wasn't told about Markdown in general * changed the image referenced to one that's easier to see * corrected the sentence about the protocol specified * retitled a section from "Hooks" to "Services and Hooks" as it had subsections about both
| image::images/markdown-08-drag-drop.png[Drag and drop images] | ||
|
|
||
| If you look back at <<_pr_references>>, you can see a small ``Parsed as Markdown'' hint above the text area. Clicking on that will give you a full cheat sheet of everything you can do with Markdown on GitHub. | ||
| If you at <<_md_drag>>, you can see a small ``Parsed as Markdown'' hint above the text area. Clicking on that will give you a full cheat sheet of everything you can do with Markdown on GitHub. |
There was a problem hiding this comment.
A verb is missing in the first part of this sentence, the one you removed (look back).
book/06-github/1-github.asc
Outdated
|
|
||
| (((GitHub))) | ||
| GitHub is the single largest host for Git repositories, and is the central point of collaboration for millions of developers and projects. | ||
| GitHub is one of the largest host for Git repositories, and is the central point of collaboration for millions of developers and projects. |
There was a problem hiding this comment.
This change is incorrect. As of right now, GitHub is still the largest single Git host. We only included a chapter on GitHub because the average reader will most likely be using it.
* changed back the first sentence to it's original form * added back a word that was deleted by mistake
|
@ben I have made the changes as requested. Any suggestions regarding my initial comment ? |
|
@ben I guess you misunderstood my question. I asked suggestion regarding the following,
|
|
Oh yeah, sorry about that. I don't think it's necessary, since the section that line is in spends 4 entire paragraphs walking through generating a token, and says this right before the code snippet:
|
|
👍 |
3 participants
A few suggestions are required for the following change,
The second line seems to need a token generated using GItHub in place of which the word TOKEN is placed. Wouldn't it be nice to add a note about that in that section?