Fix figure title #726
Merged
Fix figure title #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orphan blob d670460b4b4aece5915caf5c68d12f560a9fe3e4 is not in the figure. So the figure is not of "All the objects" but rather all the reachable ones.
|
@ben done it for the first time. Hope that's all that is required. |
ben
requested changes
Feb 21, 2017
|
|
||
| .All the objects in your Git directory. | ||
| .All the reachable objects in your Git directory. | ||
| image::images/data-model-3.png[All the objects in your Git directory.] |
There was a problem hiding this comment.
Can you update the square-bracket text as well? I forget which is which, but the text after the . and the text inside the [square brackets] are both important. One is the figure caption, the other is alt-text when rendered as HTML.
There was a problem hiding this comment.
my bad. Should be done now. Added as additional commit. Was wondering how to add the patch as an amend to the first one. Need to do some reading to know how (if it's possible).
There was a problem hiding this comment.
It's possible, but not necessary. There are some projects on GitHub that require every commit to be pristine, but this is not one of them. :)
ben
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orphan blob d670460b4b4aece5915caf5c68d12f560a9fe3e4 is not in the
figure. So the figure is not of "All the objects" but rather all the
reachable ones.
Fixes #725.