Skip to content

Conversation

aollier
Copy link
Contributor

@aollier aollier commented Feb 23, 2017

It was necessary to rewrite the section about importing a Bazaar repository into a Git repository because some operations were common regardless the user imports one or several branches.

I hope it is more clear now.

Copy link
Member

@jnavila jnavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style issues


At this point, the way to import a Bazaar repository differs according to that you have a single branch or you are working with a repository that has several branches.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not needed


Your working copy is still unsynchronized, so let's reset it:

===== Synchronize the staging area
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use the "v-ing" form in titles


===== Synchronize the staging area

Whatever the number of branches you had and the import method you used, your staging area is not synchronized with HEAD, and with the import of several branches, your working directory is not synchronized neither.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not synchronized either

Now let us have a look at the files to ignore.
As `.bzrignore`'s format is completely compatible with `.gitignore`'s format, the simplest is to rename your `.bzrignore` file.
You will also have to create a commit that contains this change for the migration:
[source,console]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing blank line


===== Ignore the files that were ignored with .bzrignore

Now let us have a look at the files to ignore.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less formal: let's

----


===== Ignore the files that were ignored with .bzrignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem "v-ing"

@aollier
Copy link
Contributor Author

aollier commented Mar 8, 2017

@jnavila I made the corrections that you suggested and I extended them to all the document to stay consistent.
@ben What do you think about the file now ?

@ben
Copy link
Member

ben commented Mar 20, 2017

LGTM. Thanks!

@ben ben merged commit 6c2bf8a into progit:master Mar 20, 2017
@aollier aollier deleted the fix branch March 21, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants