Skip to content

Conversation

JohnLukeBentley
Copy link

Swap commands for git config --global core.editor ... to properly
correspond to their respective introductions: "On a xYY system".

Mere errata.

Swap commands for `git config --global core.editor ...` to properly
correspond to their respective introductions: "On a xYY system".
@lazarljubenovic
Copy link
Contributor

See #443.

@JohnLukeBentley
Copy link
Author

JohnLukeBentley commented Mar 4, 2017

@lazarljubenovic thanks.

@i-give-up wrote in that thread:

No, the information there is correct. As far as I know, Notepad++ is only available as a 32-bit program, so it installs to

C:/Program Files on x86 system (32-bit Windows)
C:/Program Files (x86) on x64 system (64-bit Windows)

Which would be correct if Notepad++ was only available as a 32-bit program, and the change suggested by my commit would be wrong.

However, the state of affairs today, and this is probably a recent thing, is that a 64-bit Notepad++ is available. It gets more complicated: the 64-bit version doesn't support most plugins. (see https://notepad-plus-plus.org/download/v7.3.2.html)

So in effect, for the immediate future, one should generally continue to only use the 32 bit version.

How about I push two more commits:

  • Revert my prior commit; and
  • Change the text to make it clear that the commands only refer to the 32 bit version. For example (my suggested change from the master version is emphasized):

While on a Windows system, if you want to use a different text editor, such as
Notepad++, you can do the following (when installing the 32 bit version of Notepad++):
On a x86 system
$ git config --global core.editor "'C:/Program Files/Notepad++/notepad++.exe' -multiInst -no
On a x64 system
$ git config --global core.editor "'C:/Program Files (x86)/Notepad++/notepad++.exe' -multiIn

?

Edit 01: "Notepad" to "Notepad++".
Edit 02: Added link to Notepad++ downloads, showing availability of 32 at 64 bit versions; broke paragraph.

@ben
Copy link
Member

ben commented Mar 5, 2017

We have to consider the most common case for a reader who's on Windows. As of right now, it seems unlikely that anyone except plugin authors will be running 64-bit Notepad++, so the existing text is still the most relevant form.

Regardless of what happens with Notepad++, it's probable that we'll always live in a world with 32-bit editors running on 64-bit systems, so the general form of this text is still useful to the majority of readers. So once Notepad++ can recommend the 64-bit version, we might need to mention something else that ships as 32-bit to keep the usefulness of the text.

@ben ben closed this Mar 5, 2017
@JohnLukeBentley
Copy link
Author

Yes, I agree that the point of the text is less about Notepad++ specifically and more about providing example commands for, what is likely to be for the immediate future, 32 bit versions of editors.

However, in the current form the text lends itself to being misread. Evidently folk can, as I did, misread:

A. How you install 32 bit software on a 32 bit and 64 bit system (which is the intention); for
B. Different commands for 32 bit versions and 64 bit versions of software.

The evidence is in this sort of pull request being reopend, as at #671, #707, #732, arguably to the shame of all those pull requesters, including myself, given they didn't sufficiently search before hand. Shameful or not, the misreading seems to be recurrent.

So my suggestions remains: provide some kind of text to guard against that misreading. Something like "For installing 32 bit versions of ..." or some other guard.

This is also a matter I think you, @ben, can just make a call on one way or the other; and if you do decide to make changes to the text it's probably better coming from you.

@ben
Copy link
Member

ben commented Aug 15, 2017

@JohnLukeBentley, would you mind taking a look at #780?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants